Skip to content

Conversation

@Jarro01X
Copy link
Contributor

Description

This PR adds the Babelscape ALERT Dataset to PyRIT. The request for this enhancement was made in #449

Tests and Documentation

All pre-commmit hooks passed, and when I initially wrote the notebooks there were no issues returning the prompts.

@Jarro01X
Copy link
Contributor Author

Jarro01X commented Feb 25, 2025

I'm sorry. I forgot to pull any changes before the commit so there are some conflicts, let me go ahead and try to fix that

@Jarro01X
Copy link
Contributor Author

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@Jarro01X
Copy link
Contributor Author

Alright seems like I have fixed the conflict. Please let me know if there is anything missing!

Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a couple of comments. We will add integration tests soon that actually pull the dataset. No unit tests are needed I think.

Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool! Looks ready to merge pending passing pipelines 🙂 Thank you for the contribution @Jarro01X

@nina-msft nina-msft merged commit 17b8963 into Azure:main Feb 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants